JS and CSS minification should run on a separate thread

[julianlam]

The js and CSS minification methods should run on a separate nodejs process. This would free up the system in the event that assets need to be recompiled.

Make sure the process has a priority of 20, though I'm not sure how much this would help.

[akhoury]

but it doesn't matter, you would have to wait for the minification to be done before the NodeBB is ready for use.

EDIT: no?

[julianlam]

Yes, though 2 reasons :

1. Restarts take too bloody long on production mode
2. This possibly opens up the capability of not having to restart NodeBB on theme or plugin changes

[mattijle]

Yeah, about time. Anything to shorten the restart times is great.

[preeefix]

I'm in approval, how long would this take?

Also why not add hashing and caching? So that NodeBB can just compare with the file and not have to re-minify it?

[julianlam]

For bonus points, NodeBB could begin serving a stub "site_title is loading" page, though this isn't really necessary at this point.

NodeBB used to save the file to disk, although we were running into issues where the hashing process was not detecting all cases when a file changed, and was thus not reminifying the file.

We opted for a minify on app start process, but that has its own problems as well :-)

[preeefix]

If you can borrow some code from nodemon you could implement an sub app that refreshes with the latest template... No need to even restart, it just happens.