Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit login attempts, lock out the account after configurable # of attempts #1453

Closed
julianlam opened this issue Apr 29, 2014 · 4 comments
Closed
Milestone

Comments

@julianlam
Copy link
Member

Helpful to prevent brute force attempts to log into somebody's account.

@julianlam julianlam added this to the 0.5.0 milestone Apr 29, 2014
@a5mith
Copy link
Contributor

a5mith commented May 6, 2014

Would you be doing this on a timeout basis or could you maybe just forward them to the reset password page automatically after X failed login attempts. Maybe include a link to go back to login which unlocks the login page ...

Not sure how bots would cope with that though. Alternatively alter the password reset email with another link to "unlock the account" as well as one to change passwords. Not sure which would be better.

@julianlam
Copy link
Member Author

The reset system is stupidly built. It ought to be rewritten to use lru-cache instead of saving keys to redis.

Lockouts can be handled similarly.

@julianlam
Copy link
Member Author

The only downside is that resets and lockouts will reset if the server restarts, but that's a very minor downside.

@psychobunny
Copy link
Contributor

Would be nice to email the user on unsuccessful login attempt(s) as well

julianlam added a commit to NodeBB/nodebb-theme-vanilla that referenced this issue May 11, 2014
@julianlam julianlam modified the milestones: 0.4.3, 0.5.0 May 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants