Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a post does not remove it from unread lists of users #396

Closed
julianlam opened this issue Oct 11, 2013 · 2 comments
Closed

Deleting a post does not remove it from unread lists of users #396

julianlam opened this issue Oct 11, 2013 · 2 comments
Labels
Milestone

Comments

@julianlam
Copy link
Member

Note: This issue could be exploited to "bump" posts in front of viewers without actually replying to a post.

Repro

  1. Reply to a topic as account A
  2. Delete said post
  3. Account B will have that topic in their unread list, even though there was nothing new.

Gotchas

  1. Take care not to remove the topic from the unread set/list/zset if it was already there before the new reply
@julianlam
Copy link
Member Author

The tricky part of this is the way we currently handle unread state for a topic. It doesn't quite lend itself to a simple solution.

Best thing to do would be to refactor how we record the "last pid read" on a per-topic basis, which will allow us to resolve this issue.

@julianlam
Copy link
Member Author

Unfeasible given how we handle posts per user at current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant