Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache buster to production builds #586

Closed
julianlam opened this issue Nov 30, 2013 · 1 comment
Closed

Add cache buster to production builds #586

julianlam opened this issue Nov 30, 2013 · 1 comment
Assignees
Milestone

Comments

@julianlam
Copy link
Member

Running into issues where static assets are cached by the user (intended, of course), but where we'd ideally like to have assets expired the moment NodeBB is updated.

So if caching is on (NODE_ENV is not development), add a cache buster equal to the timestamp retrieved via the git log.

git log --pretty=format:'%at' -n 1

http://try.nodebb.org/css/theme.css?v=1385679062
@ghost ghost assigned julianlam Nov 30, 2013
@cnvo
Copy link
Contributor

cnvo commented Dec 1, 2013

I've been having problems with this issue as well at times and would often need to clear my cache. I figured it was just me but I guess not, so I'm glad this will be implemented. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants