Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to define multiple static directories in plugin system #926

Closed
julianlam opened this issue Feb 1, 2014 · 4 comments
Closed

Ability to define multiple static directories in plugin system #926

julianlam opened this issue Feb 1, 2014 · 4 comments
Assignees
Milestone

Comments

@julianlam
Copy link
Member

... for my own nefarious purposes, of course. 👽

@ghost ghost assigned julianlam Feb 1, 2014
@cnvo
Copy link
Contributor

cnvo commented Feb 1, 2014

👍 Muahaha.

@julianlam
Copy link
Member Author

Important!

This introduces a couple of backwards-compatible change to plugins:

  1. If staticDir is defined, it will be mapped to /plugins/{plugin-id}, same as before
  2. If staticDirs is defined, it is an object that specifies mappings, e.g. { 'test': 'assets/css' } will map /plugins/test to /node_modules/{yourPlugin}/assets/css
  3. If staticDir is defined, any entries in css will be mapped to /plugins/{plugin-id}/{file}, same as before
  4. If staticDir is not defined, any entries in css will be mapped 1:1 with a previously defined staticDir. e.g. A css file in /node_modules/{yourPlugin}/assets/css would be defined: ['/test/style.css']

So, plugins as they are will continue to work, but throw deprecation warnings now. They will stop working for v0.5.

@cnvo
Copy link
Contributor

cnvo commented Feb 2, 2014

Thanks a ton for the reference!

On Sun, Feb 2, 2014 at 1:08 PM, Julian Lam notifications@github.com wrote:

Important!

This introduces a couple of backwards-compatible change to plugins:

  1. If staticDir is defined, it will be mapped to /plugins/{plugin-id}, same
    as before
  2. If staticDirs is defined, it is an object that specifies mappings,
    e.g. { 'test': 'assets/css' } will map /plugins/test to
    /node_modules/{yourPlugin}/assets/css
  3. If staticDir is defined, any entries in css will be mapped to
    /plugins/{plugin-id}/{file}, same as before
  4. If staticDir is not defined, any entries in css will be mapped
    1:1 with a previously defined staticDir. e.g. A css file in
    /node_modules/{yourPlugin}/assets/css would be defined:
    ['/test/style.css']


Reply to this email directly or view it on GitHubhttps://github.com//issues/926#issuecomment-33907196
.

@julianlam
Copy link
Member Author

👍

@julianlam julianlam modified the milestones: 0.3.1, 0.4.0 Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants