Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS System Fixes #973

Closed
2 tasks
julianlam opened this issue Feb 9, 2014 · 2 comments · Fixed by #979
Closed
2 tasks

RSS System Fixes #973

julianlam opened this issue Feb 9, 2014 · 2 comments · Fixed by #979
Assignees
@julianlam
Labels
enhancement
Milestone
0.3.2

Comments

@julianlam
Copy link
Member

  • RSS Feeds should not persist to disk, should instead be generated on the fly (@miksago called dibs on this one)
  • Method call generating category and topic RSS feeds should be limited to a maximum of 25ish topics/posts. (@julianlam)
@julianlam julianlam added this to the 0.3.2 milestone Feb 9, 2014
@julianlam julianlam self-assigned this Feb 9, 2014
julianlam added a commit that referenced this issue Feb 9, 2014
@julianlam
retrieving only the latest 25 posts in category rss feed now - issue #…
62f1b8b 
…973
@julianlam
Copy link
Member Author

@miksago Feed.updateCategory is limited to 25, although for Topics, I'm thinking we should allow people to use ?page= in query string to load specific pages in an RSS feed. Could do the same for categories too. Will wait for your refactor and do it if I haven't done so already.

@ThisIsMissEm
Copy link
Contributor

I don't think there's much value in paginated RSS feeds, but then again, I rarely use RSS feeds.

@ThisIsMissEm ThisIsMissEm mentioned this issue Feb 9, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
enhancement
Projects
None yet
Milestone
0.3.2
Development

Successfully merging a pull request may close this issue.

On-demand feeds ThisIsMissEm/NodeBB
2 participants
@ThisIsMissEm @julianlam