Add hostname/IP support #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works from previous testing but I haven't tried this personal revision of the code. Take it with a grain of salt.
Removed the two steps and made it default to 0.0.0.0, edited the webserver.js to reflect the changes.
|
Sorry for the delay -- was watching the Breaking Bad finale. Looks good to me. Will merge it tomorrow once I give it a sanity check. Thanks @iamcardinal @BladeFarron !! |
ghost
assigned + Regular expression for port during install + Minification for public/src/forum JS files + Minification for public/src/forum/admin JS files
|
Hi @iamcardinal I made the conscious decision not to include the Re: #358, I haven't decided exactly what I'm going to do, but it involves writing a method to dynamically detect the files in I'll merge your commits without the template-specific scripts in the minifier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows one to use multiple instances of NodeBB on the same port through different IPs.