Fix problem with in ($coloumns) of #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running a filter `in city of London` was returning an SQL error saying `t1_1.city` is not defined. This should fix the problem by adding the join statement at the end similar to what is done to the `within` statement
designermonkey
added a commit
that referenced
this pull request
Dec 16, 2013
Fix problem with in ($coloumns) of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a filter
in city of Londonwas returning an SQL error sayingt1_1.cityis not defined. This should fix the problem by adding the join statement at the end
similar to what is done to the
withinstatement.I also took the freedom to edit another two lines. Looking at the code you could probably externalize $field_id and probably the $joins statement if made coherent with the other-one but I did not want to change your code structure & table names.