Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added docs for Customers endpoint #1

Merged
merged 3 commits into from
Mar 13, 2019
Merged

docs: added docs for Customers endpoint #1

merged 3 commits into from
Mar 13, 2019

Conversation

danjohnson95
Copy link
Contributor

👋

Closes designmynight/dmn#31058

I've copied over the spec I wrote in https://github.com/designmynight/collins-api/pull/1376 and made the suggested changes.

Also added some extra docs which I copied from our existing docs.

If you wanna try this out, clone the repo and spin up a HTTP server on the directory.

image

@alasdairmackenzie
Copy link
Member

Very sexy

willtj
willtj approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@willtj willtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks for this. Worth just changing the example date for opted_in_date to Y-m-d without a time but then good to merge

@danjohnson95 danjohnson95 merged commit 883b2c8 into master Mar 13, 2019
@danjohnson95 danjohnson95 deleted the initial-docs branch March 13, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtj willtj willtj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjohnson95 @alasdairmackenzie @willtj