Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Bookings endpoint #10

Merged
merged 18 commits into from
Apr 9, 2019
Merged

docs: Bookings endpoint #10

merged 18 commits into from
Apr 9, 2019

Conversation

danjohnson95
Copy link
Contributor

@danjohnson95 danjohnson95 commented Apr 8, 2019

For https://github.com/designmynight/dmn/issues/31950

Documents the endpoints for:

GET /bookings
GET /bookings/{bookingId}

Linked to https://github.com/designmynight/collins-api/pull/1586

Copy link
Member

@alasdairmackenzie alasdairmackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

Copy link
Contributor

@willtj willtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good - a few comments worth thinking about (and possibly discussing) but happy for this to be merged whenever you're ready.

bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
bookings/components/booking-filters.yaml Show resolved Hide resolved
bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
bookings/components/booking-filters.yaml Show resolved Hide resolved
bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
bookings/components/booking-filters.yaml Outdated Show resolved Hide resolved
@danjohnson95 danjohnson95 merged commit 31f0273 into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants