Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: documented the Venues endpoint #17

Merged
merged 1 commit into from
Feb 13, 2020
Merged

feat: documented the Venues endpoint #17

merged 1 commit into from
Feb 13, 2020

Conversation

danjohnson95
Copy link
Contributor

Documents the new Venues endpoint on Collins API

alasdairmackenzie
alasdairmackenzie approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@alasdairmackenzie alasdairmackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM is there some way we can generate this from the code using annotations or something similar?

@danjohnson95
Copy link
Contributor Author

@alasdairmackenzie yeah we should investigate using a tool like https://github.com/zircote/swagger-php

@danjohnson95 danjohnson95 merged commit 6daae65 into master Feb 13, 2020
@danjohnson95 danjohnson95 deleted the venue-endpoint branch February 13, 2020 11:53
@danjohnson95
Copy link
Contributor Author

FYI @designmynight/collins-account-managers new Collins API endpoints now live and documented:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alasdairmackenzie alasdairmackenzie alasdairmackenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjohnson95 @alasdairmackenzie