Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for files in fuji and guadalupe #102

Merged
merged 65 commits into from May 31, 2022
Merged

Updates for files in fuji and guadalupe #102

merged 65 commits into from May 31, 2022

Conversation

weaverba137
Copy link
Member

This PR includes at least placeholder data models for all FITS files in fuji and guadalupe.

Some data model files describe file types other than FITS. I have verified that for now the data model verification will only examine FITS files.

For future use: the file type is automatically identified, and a warning is issued if the file type is missing, or if it is an unrecognized type.

I'd like to get this merged relatively soon, so people working on individual data model files will be able to create up-to-date branches for their work. However, I want to do some more tests of the verification code before merging. This might result in changes to some of the regular expressions used to identify files.

So please review, but do not merge immediately.

@weaverba137 weaverba137 added the WIP Work in Progress label Mar 22, 2022
@weaverba137 weaverba137 self-assigned this Mar 22, 2022
@coveralls
Copy link

coveralls commented Mar 22, 2022

Coverage Status

Coverage increased (+3.6%) to 100.0% when pulling 6a688af on fuji-guadalupe into 2a7994d on main.

@weaverba137
Copy link
Member Author

@sbailey, I'm still slogging away at things like missing (possibly optional) keywords in fuji and guadalupe. In terms of code development however, I think it's very close to time to merge. Could you please go ahead and review, to the extent that's possible?

To summarize:

@weaverba137
Copy link
Member Author

Late-breaking news: the notation char[*] in place of e.g. char[7] to denote an arbitrary-length string, will also be implemented.

@geordie666
Copy link
Contributor

@weaverba137: Later in the week I want to start updating the data model for the target files. Is the intention to merge this branch relatively soon? Or should I branch off fuji-guadulupe instead of main to make my updates?

@weaverba137
Copy link
Member Author

@geordie666, I will get back to you shortly about that.

@weaverba137
Copy link
Member Author

OK, merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants