fix warnings when loading tilesfile #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to PR #98 which tried to cleanup the case where desimodel.io.load_tiles() is given a tilesfile option that exists both locally and in $DESIMODEL/data/footprint/ ($DESIMODEL wins, albeit with a warning).
The implementation in PR #98 printed incorrect warnings about collisions even when tilesfile was given with a full path and didn't exist in $DESIMODEL, e.g.:
Despite the warning message saying that it was going to pick the $DESIMODEL file (which doesn't exist), it did correctly load the local file.
This PR updates the logic to avoid the incorrect warning. Summarizing: