adds pass2program and program2pass #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverba137
previously requested changes
Oct 23, 2017
|
Added support for array-like input for |
sbailey
dismissed
weaverba137’s stale review
review requests addressed; I think this is just leftover that it hasn't been formally approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
desimodel.footprint.pass2program()anddesimodel.footprint.program2pass()to provide the mapping between the integer pass numbers and string program names in the pre-defined tiles. It uses the tile definition file itself to derive the mapping instead of hardcoding which pass is which program.This PR is a followup to desihub/desisurvey#67, which hardcoded this mapping because desimodel wasn't providing it. I'll submit a companion desisurvey PR to use this instead, while not breaking backwards compatibility.