Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sort to find_basis_template() #576

Merged
merged 2 commits into from Jan 13, 2023
Merged

added sort to find_basis_template() #576

merged 2 commits into from Jan 13, 2023

Conversation

paulmartini
Copy link
Contributor

Fix of issue #575

@coveralls
Copy link

coveralls commented Jan 13, 2023 •
edited

Coverage Status

Coverage: 46.16% (+0.06%) from 46.101% when pulling c8857b1 on findtemplate into cd02492 on main.

@paulmartini
Copy link
Contributor Author

Very straightforward change, yet important for the latest BAL templates to work with new mocks.

@moustakas
Copy link
Member

Looks fine, feel free to self-merge after adding a note to the change log.

@paulmartini paulmartini merged commit ec94577 into main Jan 13, 2023
@paulmartini paulmartini deleted the findtemplate branch January 13, 2023 21:58
@sbailey
Copy link
Contributor

sbailey commented Jan 13, 2023

I will make a new tag 0.37.1 and include it in the 23.1 software environment to be used for DR1/Iron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moustakas moustakas moustakas approved these changes

@alxogm alxogm Awaiting requested review from alxogm

@dstndstn dstndstn Awaiting requested review from dstndstn

Assignees
No one assigned
Labels
None yet
Projects
Iron
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulmartini @coveralls @moustakas @sbailey