-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad redshift pileup at z=0.89218 #1101
Comments
@deisenstein thanks. I see the peak you are talking about, but note that the "Fibers" you list are actually the indices of the stacked zbest files, which are not sorted by FIBER. For tiles they could be sorted by fiber, but in general in the future with coadding and redshift fitting across tiles that becomes ill-defined so I don't want people to get used to them being sorted in any particular order. That being said, combining zbest info with fibermap info is currently a huge pain; I'm working on a helper functions to simplify that. In the meantime I'll list the TARGETIDs and FIBERs below that correspond to those indices:
Those fibers have some suspicious groupings to investigate. |
Sorry about the fiber indexing bug. I agree that negative OII flux could
be flagged/voted against in redrock, but we should try in 2-d first.
…On Sat, Jan 16, 2021 at 11:14 PM Stephen Bailey ***@***.***> wrote:
All of these have a strong absorption feature at 9477 that is being fit
with a negative (!) [OIII] line (a known problem of overly flexible PCA),
e.g.
[image: image]
<https://user-images.githubusercontent.com/218471/104830726-4ee46000-5836-11eb-9a07-a6fbd4f4e749.png>
Also, 10 of the spectra are OBJTYPE=SKY spectra; the rest are either
ELG_SV_GFIB or ELG_SV_GTOT.
Archetypes, non-negative templates, or priors against negative emission
lines would help prevent this on the redrock side, but I'd also like to
identify and fix what is happening in the underlying spectra.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQRGX5PZM43PRVEV7Q6EDS2JPY3ANCNFSM4WA5GYHQ>
.
|
Update: the underlying problem has been considerably improved by @julienguy PR #1125 improving the sky subtraction model: However, the divot at 9477 Angstrom is the part that is getting the negative [OIII] line fit leading to the pile up at z=0.89218, and that is the feature least improved by the updated sky subtraction model. |
@sbailey, could the remaining spikes near 9440A, 9480A, and 9520A be related to excess ringing near the edges of the patches used during 2d extraction? Patch boundaries for zframe wavelength range and default patch size (nwavestep=50): zframe.wave[::50]
array([7520., 7560., 7600., 7640., 7680., 7720., 7760., 7800., 7840.,
7880., 7920., 7960., 8000., 8040., 8080., 8120., 8160., 8200.,
8240., 8280., 8320., 8360., 8400., 8440., 8480., 8520., 8560.,
8600., 8640., 8680., 8720., 8760., 8800., 8840., 8880., 8920.,
8960., 9000., 9040., 9080., 9120., 9160., 9200., 9240., 9280.,
9320., 9360., 9400., 9440., 9480., 9520., 9560., 9600., 9640.,
9680., 9720., 9760., 9800.]) |
@dmargala good call. Indeed, the divot at 9477 A was due to an unfortunate interaction between an extraction patch boundary and a bright sky line. Adjusting the patch boundary parameters following DESI-6081 (my data telecon presentation from Jan 19) fixes the problem, via desihub/specter#82. Cross posting a plot from there: |
Nice! Well spotted.
…On Sun, Feb 14, 2021 at 6:43 PM Stephen Bailey ***@***.***> wrote:
@dmargala <https://github.com/dmargala> good call. Indeed, the divot at
9477 A was due to an unfortunate interaction between an extraction patch
boundary and a bright sky line. Adjusting the patch boundary parameters
following DESI-6081 (my data telecon presentation from Jan 19) fixes the
problem, via desihub/specter#82
<desihub/specter#82>. Cross posting a plot from
there:
<https://user-images.githubusercontent.com/218471/107892360-6b2cf880-6ed9-11eb-8c86-482cf5bfc6f0.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQRGWXETJLQYTXQBY53QLS7BNZRANCNFSM4WA5GYHQ>
.
|
Underlying problem in the spectra fixed by desispec #1125 and desihub/specter#82. Closing. |
In blanc 80608/deep, I see a set of about 32 spectra very close to z=0.89218. All with acceptable ZWARN and DELTACHI2>100. Span all spectrographs.
Fibers = [ 112 268 357 486 487 488 491 492 759 769 1037 1052 1139 1463
1547 1604 2565 2694 2716 2770 2787 2798 2803 2958 3427 3435 3843 3861
3904 4596 4749 4928]
The text was updated successfully, but these errors were encountered: