tune extraction padding parameters to minimize ringing #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the boundary pixels and wavelengths used in the overlapping extraction patches, following the optimization study in DESI-6081 presented at the 2021-01-19 DESI Data telecon. This minimizes residuals at the patch boundaries. In particular, it fixes the divot at 9477 Angstroms reported in desihub/desispec#1101:
This also fixes some off-by-one indexing bugs discovered while debugging this.
I'd like to include this with the cascades run so I plan self-merge. Tests pass locally and this branch was additionally tested with real data to make the above plot; I may or may not wait for Travis tests.