bug fixes in selection of MWS_NEARBY targets in data and MWS_WD,MWS_NEARBY,STD_WD in mocks #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
approved these changes
Sep 20, 2018
geordie666
requested changes
Sep 20, 2018
There was a problem hiding this comment.
One request before merging:
Can you add a note in the docstring for isMWS_nearby noting which version of the wiki history the cuts are based on? That's the easiest way to distinguish a bug from "we haven't updated the code to reflect the wiki in a few weeks". Something like:
Notes:
- Current version (08/01/18) is version 126 on the wiki_.
geordie666
approved these changes
Sep 20, 2018
|
I'm sorry, I was too hasty and merged before allowing Travis tests to complete. I'll fix the failures in a separate PR. |
moustakas
added a commit
that referenced
this pull request
Sep 20, 2018
fix failing tests due to #383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in how we were selecting MWS_NEARBY targets in the data: we were applying a
parallax>10cut rather than a(parallax+parallax_err)>10cut (which I confirmed off-list with Boris Gaensicke and the MWS WG co-chairs).More importantly this fixes a bug in
select_mock_targets, which was using the MWS_MAIN/Galaxia mocks to select MWS_NEARBY, MWS_WD, and (consequently) STD_WD targets, which is wrong and which led to the 1000 standards/deg2 ridiculousness (see #377). With these changes I'm getting a much more sensible faint-star standard-star density of 90-100/deg2.I also took this opportunity to deprecate the BOSS (SDSS color-color) selection of standard stars, which is what we were previously using as a temporary hack.
@sbailey merging this should be a high priority of the 18.9 software release, since the results are so much more sensible. And then I'll stop. I promise. Well, not really.
@geordie666 please make sure I didn't mess anything up in
desitarget.cutsif you get a chance.