Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup for dynamic sky fiber placement #722

Merged
merged 4 commits into from May 4, 2021
Merged

Lookup for dynamic sky fiber placement #722

merged 4 commits into from May 4, 2021

Conversation

dstndstn
Copy link
Contributor

@dstndstn dstndstn commented May 4, 2021

This is the code we're using in fiberassign to do the lookup for good sky locations in the "skybricks" data product. Stephen requested it go in desitarget so he can use it in the spectro pipeline.

@coveralls
Copy link

coveralls commented May 4, 2021

Coverage Status

Coverage decreased (-0.3%) to 59.213% when pulling 258973e on dynamic-sky into 073e430 on master.

@geordie666
Copy link
Contributor

@dstndstn: This PR looks fine, and it's OK to merge it. Before you do, though, make sure to update the changes documentation and the API for read-the-docs.

@sbailey
Copy link
Contributor

sbailey commented May 4, 2021

Thanks; I also tested that this works as expected, and updated the changes.rst and api.rst so that @dstndstn can focus on other topics. I'll merge after tests re-pass.

@sbailey sbailey merged commit e59fc85 into master May 4, 2021
@sbailey sbailey deleted the dynamic-sky branch May 4, 2021 23:40
@dstndstn
Copy link
Contributor Author

dstndstn commented May 5, 2021

Wow, thanks @sbailey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants