Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #736 which I will close after submitting this.
This provides tools for overriding SUBPRIORITY when generating target files, to work around the accidental SUBPRIORITY reassignments from fiberassign in May 2021:
desitarget.subpriority.override_subpriority(targets, override)
- override targets['SUBPRIORITY'] in-place, for those TARGETIDs that appear in the override table.desitarget.subpriority.get_fiberassign_subpriorities
used to scrape fiberassign TARGETS HDUs to build override lists for dark, bright, and sky.select_targets --dark-subpriorities ... --bright-subpriorities ...
options to provide override listsselect_skies --sky-subpriorities ...
andsupplement_skies --sky-subpriorities subpriorities-sky.fits
options to provide sky SUBPRIORITY override listsOne change of behavior in
write_targets
et al:write_targets(..., subpriority=True)
.Examples in
/global/cscratch1/sd/sjbailey/desi/targets/default
andoverride/
. I believe I have tested the following but would appreciate additional checks:@araichoor @geordie666