New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add [grz]fiberflux optional arguments to fix (now-broken) desisim/templates code #786
Conversation
This all looks fine so far, but I'll hold off on my review until it is now longer a Note that we've been having failures on |
I don't understand the pull vs. push test failure difference, but the test failures look like the same fitsio/numpy compatibility issue that was fixed in desihub/desispec#1566. That took a bit of installation-fu from @weaverba137 resulting in https://github.com/desihub/desispec/blob/5859c624b14619718fa4a67b152bcce193683395/.github/workflows/python-package.yml#L73-L78
|
Let me know if you need assistance in adjusting the test configuration. As far as the difference between push and pull request, I speculate that it could have some subtle difference in the order in which packages are installed, and thus fitsio is built against the ultimately-installed version of numpy in one case but not the other. |
Thank you for the offer, @weaverba137! If you have time I would be grateful for your help updating the tests. If you have any time to take a look at this PR which is also gloriously failing tests, I'd be grateful--
|
OK, I'll take a look. |
@geordie666 this PR is ready for your review. FYI, I'd like to merge this PR before desihub/desisim#556, which has several other moving pieces (including this one). |
@moustakas: I think this is fine to merge. You haven't changed anything else in So, as I said, feel free to merge this to make further progress in desisim. |
Our
desisim.templates
code has been broken for some time (see desihub/desisim#553) becausedesisim
lagged behind the changes made todesitarget
.This PR is the minimal set of changes to get
desisim.templates
working again, although I want to add some additional tests on thedesisim
side (companion PR is forthcoming) so let's not merge yet.