New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore select_mock_targets to working order #788
Conversation
@geordie666 @weaverba137 @sbailey this PR is now ready for review. However, I need help setting up the unit tests to test the mock code (specifically, For the record, the mock unit tests pass with a local check-out of this branch using
A couple quick notes:
|
For the record: it looks like desitarget already depends on desisim, and of course, desisim already depends on desitarget. Thus we have a circular dependency. It hasn't caused problems so far, but those are always a potential source of pain. For the sharedmem issue, it would be interesting to compare what version of Python you are using on your laptop to the version at NERSC. If you're using the DESI software stack at all, I think that is still Python 3.8, which would appear to contradict the ticket. |
On my laptop I was using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moustakas: As you mention, most of your changes are specific to the mocks, which I didn't review too carefully. For the more general parts, I've added two very minor comments for you to address. I'm happy to sign off on this, though.
[WIP]
Building on #786, and on the heals of the major fixes in the template-generating code in desihub/desisim#559, the purpose of this PR is to restore
select_mock_targets
to working order (it's been broken for many months, if not a year) and to address a number of open bugs and issues, including #735, #745, #747, and others.