Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add brick_tan_wcs_size() function: compute required size of tiles #177

Merged
merged 3 commits into from Oct 27, 2021

Conversation

dstndstn
Copy link
Contributor

... in order to make overlapping TAN-projection WCS tiles on brick centers

For example, a Bricks object with 0.25-degree spacing requires TAN WCS tiles at least 0.26445 degrees across to guarantee that tiles on Bricks centers will cover the entire sky without holes.

…make overlapping TAN-projections on brick centers
@weaverba137
Copy link
Member

This looks OK so far, but be sure to update the change log before I do a formal review.

@coveralls
Copy link

coveralls commented Oct 27, 2021

Coverage Status

Coverage increased (+0.3%) to 66.903% when pulling fd62a3f on add-tan-size into 129dc44 on master.

@weaverba137
Copy link
Member

Any further changes planned?

@dstndstn
Copy link
Contributor Author

Thanks for your fixes. I didn't have anything further planned.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check the units on the return value. Otherwise this can be merged.

py/desiutil/brick.py Show resolved Hide resolved
@weaverba137 weaverba137 merged commit 9fe5ceb into master Oct 27, 2021
@weaverba137 weaverba137 deleted the add-tan-size branch October 27, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants