Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the desiutil installation test at NERSC. It was previously failing because it was picking
/global/common/edison/contrib/desi/code/desiutil/master
as the installation location, and then erroring because that already existed.The test already included some logic to unset
$DESI_PRODUCT_ROOT
to try to avoid this, but that was unsuccessful because if that isn't set then the installation logic defaults to using/global/common/edison/contrib/desi/code
anyway.The workaround here is to test installing a fake branch "test-blat-foo". An alternate workaround would have been to set
$DESI_PRODUCT_ROOT
to some other location instead of unsetting it.Note: I purposefully didn't update changes.rst since this seems too small to bother cluttering the human-friendly log of important changes to know about; i.e. let's keep the changes.rst focused on features and changes in functionality. @weaverba137 can override me as owner of this repo though.
For the record, this is what I get on edison when using desiutil master
python setup.py test
: