Fix bugs that caused bricks to be larger than bricksize. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith sizes larger than desired bricksize.
… pole if bricksize does not evenly divide 180 degrees. Also make comments in test case reflect that the tests now pass
weaverba137
requested changes
Sep 7, 2017
| @@ -9,9 +9,13 @@ Change Log | |||
| in an installed package, as opposed to a git checkout (PR `#80`_). | |||
| * Fixed bug in :meth:`desiutil.brick.Bricks.brick_radec` handling scalar inputs | |||
| (PR `#81`_). | |||
| * Fixed bugs that could cause bricks to be slightly too big, and that | |||
| @@ -85,6 +85,43 @@ def test_brickvertices_wrap(self): | |||
| self.assertEqual(np.max(b1[:,0])-np.min(b1[:,0]), 360.) | |||
| self.assertTrue(np.all(b1[:,1] >= -90.)) | |||
|
|
|||
| def test_uneven_bricksize(self): | |||
There was a problem hiding this comment.
Please add a __doc__ string.
weaverba137
approved these changes
Sep 7, 2017
|
One non-critical test is stalled, merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some implicit assumptions that bricksize evenly divides 180 degrees: