Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tagalong argument in the docstr #430

Merged
merged 2 commits into from May 11, 2022
Merged

add tagalong argument in the docstr #430

merged 2 commits into from May 11, 2022

Conversation

araichoor
Copy link
Contributor

This PR adds the tagalong argument in the docstr of the functions using it in targets.py and assign.py.

This was raised in #429 (and the taglong was introduced in PR #353).

tagalong is also used in some vis.py functions, but I m not at all familiar with those, and they haven t any docstr yet, so I didn t do any modification there.

@dstndstn
Copy link
Contributor

Could you maybe drop the "A new one can be created..." sentence except for the one on "load_target_file"? Because a newly-created one is passed to the load functions, then that same one has to be passed to the write functions.

@araichoor
Copy link
Contributor Author

Sure, done.
Thanks for the check!

@forero
Copy link
Member

forero commented Apr 28, 2022

Thanks @dstndstn @araichoor !

@araichoor araichoor merged commit bf17ccb into master May 11, 2022
@araichoor araichoor deleted the docstr_tagalong branch November 3, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants