Move bytes::set_random implementation to a .cpp.

CMakeLists.txt

@@ -110,6 +110,7 @@ PRIVATE
     base/basic_types.h
     base/binary_guard.h
     base/build_config.h
+    base/bytes.cpp
     base/bytes.h
     base/call_delayed.cpp
     base/call_delayed.h

base/bytes.cpp

@@ -0,0 +1,21 @@
+// This file is part of Desktop App Toolkit,
+// a set of libraries for developing nice desktop applications.
+//
+// For license and copyright information please follow this link:
+// https://github.com/desktop-app/legal/blob/master/LEGAL
+//
+#include "base/bytes.h"
+
+#include "base/openssl_help.h"
+
+namespace bytes {
+
+void set_random(span destination) {
+	if (!destination.empty()) {
+		RAND_bytes(
+			reinterpret_cast<unsigned char*>(destination.data()),
+			destination.size());
+	}
+}
+
+} // namespace bytes

base/bytes.h

@@ -149,8 +149,7 @@ vector concatenate(Args &&...args) {
 	return result;
 }
 
-template <
-	typename SpanRange>
+template <typename SpanRange>
 vector concatenate(SpanRange args) {
 	auto size = std::size_t(0);
 	for (const auto &arg : args) {
@@ -166,7 +165,6 @@ vector concatenate(SpanRange args) {
 	return result;
 }
 
-// Implemented in base/openssl_help.h
 void set_random(span destination);
 
 } // namespace bytes

base/openssl_help.h

@@ -593,15 +593,3 @@ inline bytes::vector HmacSha256(
 }
 
 } // namespace openssl
-
-namespace bytes {
-
-inline void set_random(span destination) {
-	if (!destination.empty()) {
-		RAND_bytes(
-			reinterpret_cast<unsigned char*>(destination.data()),
-			destination.size());
-	}
-}
-
-} // namespace bytes