Font tweaks for electron 9 #10330
Merged
Font tweaks for electron 9 #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the same emoji font fallback chain that GitHub.com uses in order to work around the rendering of certain emoji on Windows (see electron/electron#24426).
While we're at it I'm also replacing our system font fallback chain with the new system-ui font-alias that lets us leverage Chromium's logic for determining what the system font is.
Lastly I've updated our monospace font stack to match that of GitHub.com (by adding SFMono-Regular as the highest priority monospace font).
Ideally I would like to use the ui-sans-serif and ui-monospace font aliases but we'll have to wait a while for them to be supported
Screenshots
Note that there's no difference on Windows and the exact before state depends on the fonts installed on the system.
Release notes
Notes: [Improved] Use system monospace font for diffs on macOS