List some branches #1126
Merged
List some branches #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obsoleted when expandable foldouts was removed
For some reason this regressed at some point and the only way I could get it to work was by expanding the width some arbitrary amount. At the same time I moved the scrollbar out by 3px so that it wouldn't interfere with the resize handle of a Resizable component
|
I think this is ready for review! |
joshaber
suggested changes
Apr 5, 2017
| @@ -222,9 +222,31 @@ export interface IRepositoryState { | |||
| } | |||
|
|
|||
| export interface IBranchesState { | |||
| /** | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
app/src/ui/branches/branch-list.tsx
Outdated
|
|
||
| private getGroupLabel(identifier: BranchGroupIdentifier) { | ||
| if (identifier === 'default') { | ||
| return 'Default Branch' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
app/src/ui/lib/filter-list.tsx
Outdated
| * selected row is clicked on. | ||
| * | ||
| * @param selectedItem - The item that was just selected | ||
| * @param source - The kind of user action that provoced the change, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
app/src/ui/merge-branch/merge.tsx
Outdated
| } | ||
| } | ||
|
|
||
| private onItemClick = (item: Branch) => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
🐨 |
joshaber
suggested changes
Apr 5, 2017
app/src/ui/branches/branch-list.tsx
Outdated
| const branch = item.branch | ||
| this.props.onItemClick(branch) | ||
| if (this.props.onItemClick) { | ||
| this.props.onItemClick(item.branch) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joshaber
approved these changes
Apr 5, 2017
Merged
This was referenced Nov 5, 2022
This was referenced Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this possible I have
AutoSizercomponent from react-virtualized in favor of ResizeObserverAutoSizerfailed to provide a correct size when used inside a dialog. The dialog gets mounted in the DOM but doesn't appear until we callshowModalso I assume that has something to do with it. Either way, I couldn't get it to work except by holding off on mounting the list until some arbitrary time after we'd calledshowModal.experimentalFeaturesis turned off by going back to using theAutoSizer.AutoSizerdetects resizes (it injects a tracking element into the DOM).Additionally this removes one layer of nesting on Windows by returning an array from
List#renderContentsinstead of wrapping the grid and the fake scroll inside a div.Fixes #749