List some branches

app/src/ui/branches/branch-list.tsx

@@ -47,7 +47,7 @@ interface IBranchListProps {
   readonly onFilterKeyDown?: (filter: string, event: React.KeyboardEvent<HTMLInputElement>) => void
 
   /** Called when an item is clicked. */
-  readonly onItemClick: (item: Branch) => void
+  readonly onItemClick?: (item: Branch) => void
 
   /**
    * This function will be called when the selection changes as a result of a
@@ -56,7 +56,7 @@ interface IBranchListProps {
    * selected row is clicked on.
    *
    * @param selectedItem - The Branch that was just selected
-   * @param source       - The kind of user action that provoced the change,
+   * @param source       - The kind of user action that provoked the change,
    *                       either a pointer device press, or a keyboard event
    *                       (arrow up/down)
    */
@@ -107,11 +107,11 @@ export class BranchList extends React.Component<IBranchListProps, IBranchListSta
 
   private getGroupLabel(identifier: BranchGroupIdentifier) {
     if (identifier === 'default') {
-      return 'Default Branch'
+      return __DARWIN__ ? 'Default Branch' : 'Default branch'
     } else if (identifier === 'recent') {
-      return 'Recent Branches'
+      return __DARWIN__ ? 'Recent Branches' : 'Recent branches'
     } else if (identifier === 'other') {
-      return 'Other Branches'
+      return __DARWIN__ ? 'Other Branches' : 'Other branches'
     } else {
       return assertNever(identifier, `Unknown identifier: ${identifier}`)
     }
@@ -122,8 +122,9 @@ export class BranchList extends React.Component<IBranchListProps, IBranchListSta
   }
 
   private onItemClick = (item: IBranchListItem) => {
-    const branch = item.branch
-    this.props.onItemClick(branch)
+    if (this.props.onItemClick) {
+        this.props.onItemClick(item.branch)
+    }
   }
 
   private onSelectionChanged = (selectedItem: IBranchListItem | null, source: SelectionSource) => {

app/src/ui/lib/filter-list.tsx

@@ -62,7 +62,7 @@ interface IFilterListProps<T extends IFilterListItem> {
   readonly renderPreList?: () => JSX.Element | null
 
   /** Called when an item is clicked. */
-  readonly onItemClick: (item: T) => void
+  readonly onItemClick?: (item: T) => void
 
   /**
    * This function will be called when the selection changes as a result of a
@@ -71,7 +71,7 @@ interface IFilterListProps<T extends IFilterListItem> {
    * selected row is clicked on.
    *
    * @param selectedItem - The item that was just selected
-   * @param source       - The kind of user action that provoced the change,
+   * @param source       - The kind of user action that provoked the change,
    *                       either a pointer device press, or a keyboard event
    *                       (arrow up/down)
    */
@@ -212,10 +212,13 @@ export class FilterList<T extends IFilterListItem> extends React.Component<IFilt
   }
 
   private onRowClick = (index: number) => {
-    const row = this.state.rows[index]
-    if (row.kind !== 'item') { return }
+    if (this.props.onItemClick) {
+      const row = this.state.rows[index]
 
-    this.props.onItemClick(row.item)
+      if (row.kind === 'item') {
+        this.props.onItemClick(row.item)
+      }
+    }
   }
 
   private onRowKeyDown = (row: number, event: React.KeyboardEvent<any>) => {

app/src/ui/list.tsx

@@ -121,7 +121,7 @@ interface IListProps {
    * selected row is clicked on.
    *
    * @param row    - The index of the row that was just selected
-   * @param source - The kind of user action that provoced the change, either
+   * @param source - The kind of user action that provoked the change, either
    *                 a pointer device press, hover (if selectOnHover is set) or
    *                 a keyboard event (arrow up/down)
    */

app/src/ui/merge-branch/merge.tsx

@@ -83,9 +83,6 @@ export class Merge extends React.Component<IMergeProps, IMergeState> {
     }
   }
 
-  private onItemClick = (item: Branch) => {
-  }
-
   private onSelectionChanged = (selectedBranch: Branch | null) => {
     if (selectedBranch) {
       this.setState({ selectedBranch })
@@ -136,7 +133,6 @@ export class Merge extends React.Component<IMergeProps, IMergeState> {
             defaultBranch={this.props.defaultBranch}
             recentBranches={this.props.recentBranches}
             onFilterKeyDown={this.onFilterKeyDown}
-            onItemClick={this.onItemClick}
             selectedBranch={selectedBranch}
             onSelectionChanged={this.onSelectionChanged}
           />