Replace moment relative time formatting with custom formatRelative #14149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
previously approved these changes
Mar 11, 2022
tidy-dev
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #14148 this PR replaces all of our uses of moment's relative time formatting in favor of a custom (based on GitHub.com's relative-time.ts functions) relative time formatter.
One noteworthy, user facing change, in this PR is the removal of our ultra-compact (or so called "abbreviated") relative time format in favor of the regular format
Before
After
This is in line with what GitHub.com does these days. Commits, PR lists, etc, all use the regular format instead of the micro format.
With this we're able to unship
moment-duration-formatand we're inches away from unshipping all of momentRelease notes
Notes: no-notes