Prevent closing the app while it's updating

[sergiou87]

Closes #7055
Closes #5197

Description

After digging into some complaints from users about the app leaving temporary files after updates, and with a hint from one of the said users, I noticed how closing GitHub Desktop while it's being updated can cause either a corrupted installation (unable to open the next time) or just cluttering up the user's harddrive.

This PR attempts to prevent users from closing Desktop while an update is in progress by showing a dialog when the user tries to quit the app. From that dialog, the user might choose to quit the app anyway. Otherwise, the app will quit automatically when the update is completed.

Screenshots

Screen.Recording.2022-10-05.at.17.41.22.mov

Release notes

Notes: [Fixed] Prevent closing the GitHub Desktop while it's being updated

[niik]

First look at this seems like a decent approach. It does feel a bit weird that a dialog is responsible for quitting the app but I think I can learn to live with it 😄

[sergiou87]

It does feel a bit weird that a dialog is responsible for quitting the app but I think I can learn to live with it 😄

@niik I intend to go back to the dispatcher -> app store for that, which should be a bit cleaner and more in line with the rest of our dialogs. This is just kind of a PoC, so as long as you don't see any holes in this logic (knowing closing/quitting are different actions on macOS), I'm happy 😂 Thanks for the quick review!! 🙌

[sergiou87]

Changed it to look like this:

Screen.Recording.2022-10-10.at.13.37.15.mov

[sergiou87]

After a few more changes, it finally looks like this:

[sergiou87]

I just added a feature flag, but other than that this should be ready for another review @niik 🙏

[niik]

Only a stylistic request. One other thing though, should we perhaps call cancelQuittingApp from the unmount callback of the InstallingUpdate dialog if the dialog is being unmounted without an explicit choice either way from the user? Like if the user clicks on an open in Desktop link on GitHub.com (i.e. open x-github-desktop-dev-auth://openRepo//) while the dialog is open?

[sergiou87]

That's a very good point!