Add Notepad++ External Editor for Windows

.travis.yml

@@ -50,7 +50,7 @@ cache:
     - $HOME/.cache/electron-builder
 
 before_install:
-  - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.3.2
+  - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.5.1
   - export PATH=$HOME/.yarn/bin:$PATH
 
 install:

app/src/lib/editors/win32.ts

@@ -18,6 +18,7 @@ export enum ExternalEditor {
   VisualStudioCodeInsiders = 'Visual Studio Code (Insiders)',
   SublimeText = 'Sublime Text',
   CFBuilder = 'ColdFusion Builder',
+  NotepadPlusPlus = 'Notepad++',
 }
 
 export function parse(label: string): ExternalEditor | null {
@@ -36,6 +37,9 @@ export function parse(label: string): ExternalEditor | null {
   if (label === ExternalEditor.CFBuilder) {
     return ExternalEditor.CFBuilder
   }
+  if (label === ExternalEditor.NotepadPlusPlus) {
+    return ExternalEditor.NotepadPlusPlus
+  }
 
   return null
 }
@@ -113,6 +117,21 @@ function getRegistryKeys(
             'SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Adobe ColdFusion Builder 2016',
         },
       ]
+    case ExternalEditor.NotepadPlusPlus:
+      return [
+        //64-bit version of Notepad++
+        {
+          key: HKEY.HKEY_LOCAL_MACHINE,
+          subKey:
+            'SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Notepad++',
+        },
+        // 32-bit version of Notepad++
+        {
+          key: HKEY.HKEY_LOCAL_MACHINE,
+          subKey:
+            'SOFTWARE\\Wow6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Notepad++',
+        },
+      ]
 
     default:
       return assertNever(editor, `Unknown external editor: ${editor}`)
@@ -140,6 +159,8 @@ function getExecutableShim(
       return Path.join(installLocation, 'subl.exe')
     case ExternalEditor.CFBuilder:
       return Path.join(installLocation, 'CFBuilder.exe')
+    case ExternalEditor.NotepadPlusPlus:
+      return Path.join(installLocation, 'notepad++.exe')
     default:
       return assertNever(editor, `Unknown external editor: ${editor}`)
   }
@@ -180,6 +201,10 @@ function isExpectedInstallation(
           displayName === 'Adobe ColdFusion Builder 2016') &&
         publisher === 'Adobe Systems Incorporated'
       )
+    case ExternalEditor.NotepadPlusPlus:
+      return (
+        displayName.startsWith('Notepad++') && publisher === 'Notepad++ Team'
+      )
     default:
       return assertNever(editor, `Unknown external editor: ${editor}`)
   }
@@ -258,6 +283,16 @@ function extractApplicationInformation(
     return { displayName, publisher, installLocation }
   }
 
+  if (editor === ExternalEditor.NotepadPlusPlus) {
+    const displayName = getKeyOrEmpty(keys, 'DisplayName')
+    const publisher = getKeyOrEmpty(keys, 'Publisher')
+    const installLocation = getKeyOrEmpty(keys, 'UninstallString').replace(
+      'uninstall.exe',
+      ''
+    )
+    return { displayName, publisher, installLocation }
+  }
+
   return assertNever(editor, `Unknown external editor: ${editor}`)
 }
 
@@ -314,12 +349,14 @@ export async function getAvailableEditors(): Promise<
     codeInsidersPath,
     sublimePath,
     cfBuilderPath,
+    notepadPlusPlusPath,
   ] = await Promise.all([
     findApplication(ExternalEditor.Atom),
     findApplication(ExternalEditor.VisualStudioCode),
     findApplication(ExternalEditor.VisualStudioCodeInsiders),
     findApplication(ExternalEditor.SublimeText),
     findApplication(ExternalEditor.CFBuilder),
+    findApplication(ExternalEditor.NotepadPlusPlus),
   ])
 
   if (atomPath) {
@@ -357,5 +394,12 @@ export async function getAvailableEditors(): Promise<
     })
   }
 
+  if (notepadPlusPlusPath) {
+    results.push({
+      editor: ExternalEditor.NotepadPlusPlus,
+      path: notepadPlusPlusPath,
+    })
+  }
+
   return results
 }

appveyor.yml

@@ -24,6 +24,7 @@ version: "{build}"
 install:
   - cmd: regedit /s script\default-to-tls12-on-appveyor.reg
   - ps: Install-Product node $env:nodejs_version $env:platform
+  - choco install yarn
   - git submodule update --init --recursive
   - yarn install --force
 

circle.yml

@@ -25,7 +25,7 @@ dependencies:
     # everything is terrible, but we must march on
     - brew link --overwrite node@8 --force
     # workaround for yarn installation issue
-    - curl -o- -L https://yarnpkg.com/install.sh | TERM=xterm bash
+    - curl -o- -L https://yarnpkg.com/install.sh | TERM=xterm bash -s -- --version 1.5.1
 
   override:
     - yarn install --force

docs/technical/editor-integration.md

@@ -25,9 +25,11 @@ The source for the editor integration on Windows is found in
 These editors are currently supported:
 
  - [Atom](https://atom.io/)
- - [Visual Studio Code](https://code.visualstudio.com/) - both stable and Insiders channel
+ - [Visual Studio Code](https://code.visualstudio.com/)
+ - [Visual Studio Code (Insiders)](https://code.visualstudio.com/insiders/)
  - [Sublime Text](https://www.sublimetext.com/)
  - [ColdFusion Builder](https://www.adobe.com/products/coldfusion-builder.html)
+ - [Notepad++](https://notepad-plus-plus.org/)
 
 These are defined in an enum at the top of the file:
 
@@ -38,6 +40,7 @@ export enum ExternalEditor {
   VisualStudioCodeInsiders = 'Visual Studio Code (Insiders)',
   SublimeText = 'Sublime Text',
   CFBuilder = 'ColdFusion Builder',
+  NotepadPlusPlus = 'Notepad++'
 }
 ```