Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added focus on close button to license modal #6220

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

bblarney
Copy link
Contributor

Overview

Closes #6137

Description

  • The close button is now in focus on the 'License and Open Source Notes' modal within the 'About Github Desktop' modal. Old behavior would open new window on enter key press inside the modal, new behavior closes the modal. I used the code and comments from the T&C file for consistency.

New behavior:

  1. Open "About GitHub Desktop"
  2. Click on "License and Open Source Notices"
  3. Click Enter/Return
  4. "Close" button invoked and the modal closes.

Any changes needed let me know! Thanks

Release notes

Notes: no notes

@bblarney bblarney changed the title added focus on close button to lisence modal added focus on close button to license modal Nov 17, 2018
@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 19, 2018
@shiftkey
Copy link
Member

@bblarney thanks for opening this up!

I haven't had a chance to review it yet, but I wanted to point out that the email address used in the commits isn't found in your GitHub account (so you won't be credited as a contributor on this page if we end up merging the PR).

Copy link
Contributor

@iAmWillShepherd iAmWillShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@iAmWillShepherd iAmWillShepherd merged commit c78c44d into desktop:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants