Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows app menu #689

Merged
merged 129 commits into from
Dec 1, 2016
Merged

Windows app menu #689

merged 129 commits into from
Dec 1, 2016

Conversation

niik
Copy link
Member

@niik niik commented Nov 25, 2016 •
edited
Loading

This implements the hamburgler menu on Windows.

app-menu

TODO

  • Render the menu
  • Multi-level selection
  • Item activation (click)
  • Only enable for non-osx
  • Try to find a nicer model/state abstraction
  • Alt button should toggle menu globally on Windows
  • Merge menus from main-process
  • Windows access keys
  • Add accelerators for built-in commands like Fullscreen
  • Adapt Menu structure to fit Windows standard menus

@niik
Allow the renderer to ask for the app menu
93cb3ad
@niik
Store the app menu in the AppState
81acb5c
@niik
Request the app menu on launch
ffe31d4
@niik
Let's deal with menus in main.ts
f52dd27
@niik
Send menu updates when item state changes
9fc8f59
@niik
Add app menu toolbar button
dd77163
@niik
Fix margins in toolbar buttons
cf4e7f2
@niik
Initial app menu
1032261
@niik
Actually render it
61595d0
@niik
Some initial styling
bcd3ede
@niik
Some more margins and smaller arrows
a2045ce
@niik
Allow storing app menu selection through dispatcher
3eaaf6c
@niik
Selection events from panes
46b2d61
@niik
Initial selection wire-up
5f5417b
@niik
Fix pane border
aec76e1
@niik
No more top padding
7e78740
@niik
Ellipsis label only
727ef0b
@niik
Menu item contents centered vertically
dffbf79
@niik
Wire up selected item
5c7abc9
@niik
Re render when items change
42c1a08
@niik
Clear app menu selection on open
69c0813
@niik
Wider menu panes
b7b0915
@niik
Allow selection to follow pointer in lists
a1b8d07
@niik
Better name
fe8edbe
@niik
Maintain focus when selectOnHover is set
f7161a3
@niik
Keep focus style for parent items
211a13b
@niik
Try a different model approach for menus
59cc3cc
@niik
Delay opening and closing submenus
50e15d0
@niik niik mentioned this pull request Nov 26, 2016
Merged
@niik
Copy link
Member Author

niik commented Dec 1, 2016

Thanks for the thorough review @joshaber, great notes. This is ready for another lookiloo

@joshaber
Copy link
Contributor

joshaber commented Dec 1, 2016

giphy

@joshaber joshaber merged commit e980af0 into master Dec 1, 2016
@joshaber joshaber deleted the windows-menu branch December 1, 2016 15:17
@niik niik mentioned this pull request Jan 30, 2017
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2021
Open
mijiang168 pushed a commit to mijiang168/desktop that referenced this pull request Apr 22, 2022
@shiftkey
Add additional validation to find the app-specific argument we require (
05445fb 
desktop#687 desktop#689)
mijiang168 pushed a commit to mijiang168/desktop that referenced this pull request Apr 22, 2022
@shiftkey
Add additional validation to find the app-specific argument we require (
77ef11a 
desktop#687 desktop#689)
yasuking0304 pushed a commit to yasuking0304/desktop that referenced this pull request Jan 22, 2023
@shiftkey
Add additional validation to find the app-specific argument we require (
f230a6e 
desktop#687 desktop#689)
yasuking0304 pushed a commit to yasuking0304/desktop that referenced this pull request Jan 22, 2023
@shiftkey
Add additional validation to find the app-specific argument we require (
1bf1d8d 
desktop#687 desktop#689)
yasuking0304 pushed a commit to yasuking0304/desktop that referenced this pull request Mar 9, 2023
@shiftkey
Add additional validation to find the app-specific argument we require (
296a97d 
desktop#687 desktop#689)
yasuking0304 pushed a commit to yasuking0304/desktop that referenced this pull request Mar 9, 2023
@shiftkey
Add additional validation to find the app-specific argument we require (
e406e35 
desktop#687 desktop#689)
ahmetsait pushed a commit to ahmetsait/github-desktop that referenced this pull request Feb 4, 2024
@shiftkey
Add additional validation to find the app-specific argument we require (
696eb6a 
desktop#687 desktop#689)
ahmetsait pushed a commit to ahmetsait/github-desktop that referenced this pull request Feb 4, 2024
@shiftkey @ahmetsait
Add additional validation to find the app-specific argument we require (
77cda20 
desktop#687 desktop#689)
ahmetsait pushed a commit to ahmetsait/github-desktop that referenced this pull request Feb 7, 2024
@shiftkey
Add additional validation to find the app-specific argument we require (
40c0bf4 
desktop#687 desktop#689)
ahmetsait pushed a commit to ahmetsait/github-desktop that referenced this pull request Apr 12, 2024
@shiftkey
Add additional validation to find the app-specific argument we require (
b6a2376 
desktop#687 desktop#689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshaber joshaber joshaber approved these changes

Assignees

@joshaber joshaber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niik @joshaber