Status codes 201-299 shouldn't be errors #147
Labels
Comments
|
This is fixed in master |
|
Whoops, the first issue is fixed in master, the error codes haven't yet been addressed. |
reconbot
changed the title
|
@reconbot Ran into this one today when building video/media uploads (via the three-step chunked process as per #110 Right now I have a cumbersome conditional for handling HTTP 2xx responses. Get this fixed and shipped and I can provide an example of using this module for three-step media uploads :D. |
reconbot
added a commit
that referenced
this issue
Aug 3, 2016
- Bonus! Max complexity and max statements have fallen - exercises the REST api capabilities Fixes #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a "return" missing in line 144 of twitter.js. Without it, a callback will be called twice if there is an exception. (Which happens if you try to upload in chunks, because this can't be JSON parsed, or if the connection to the internet is temporary lost)
Also status codes 201,202 and 204 aren't errors and should be included in line 149. They happen when uploading chunks.
The text was updated successfully, but these errors were encountered: