Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix outdated permissions CLI examples #1008

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

leobragaz
Copy link
Contributor

@leobragaz leobragaz commented Sep 22, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@leobragaz leobragaz requested a review from a team as a code owner September 22, 2022 16:48
@github-actions github-actions bot added x/CLI x/subspaces Issue on the x/subspaces module labels Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 80.53% // Head: 80.43% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (8422e60) compared to base (581f6fc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   80.53%   80.43%   -0.11%     
==========================================
  Files         175      176       +1     
  Lines       15270    15379     +109     
==========================================
+ Hits        12298    12370      +72     
- Misses       2444     2470      +26     
- Partials      528      539      +11     
Impacted Files Coverage Δ
x/profiles/wasm/querier.go 51.63% <0.00%> (-0.58%) ⬇️
x/profiles/module.go 9.41% <0.00%> (-0.35%) ⬇️
x/profiles/legacy/v8/store.go 70.23% <0.00%> (ø)
app/app.go 88.17% <0.00%> (+0.01%) ⬆️
x/posts/keeper/msg_server.go 89.91% <0.00%> (+0.05%) ⬆️
x/profiles/wasm/msg_parser.go 91.42% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RiccardoM RiccardoM changed the title fix: Fixed outdated permissions CLI examples fix: fix outdated permissions CLI examples Sep 22, 2022
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Sep 22, 2022
@mergify mergify bot merged commit 6b62328 into master Sep 26, 2022
@mergify mergify bot deleted the leonardo/fix-permissions-cli-examples branch September 26, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants