Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pagination #544

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Improve pagination #544

merged 2 commits into from
Jul 7, 2021

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Jul 7, 2021

Description

This PR is the implementation of #535.
Closes #535

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #544 (81681f9) into master (66e0c98) will decrease coverage by 0.18%.
The diff coverage is 76.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   81.82%   81.63%   -0.19%     
==========================================
  Files          91       91              
  Lines        4736     4733       -3     
==========================================
- Hits         3875     3864      -11     
- Misses        667      671       +4     
- Partials      194      198       +4     
Impacted Files Coverage Δ
x/staging/posts/keeper/grpc_query.go 75.00% <70.83%> (-5.81%) ⬇️
x/profiles/keeper/grpc_query.go 74.10% <72.72%> (-2.42%) ⬇️
x/staging/subspaces/keeper/grpc_query.go 83.87% <92.30%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e0c98...81681f9. Read the comment docs.

@dadamu dadamu marked this pull request as ready for review July 7, 2021 09:29
@RiccardoM RiccardoM merged commit b066424 into master Jul 7, 2021
@RiccardoM RiccardoM deleted the paul/improve-paginate branch July 7, 2021 09:58
RiccardoM pushed a commit that referenced this pull request Aug 6, 2021
See PR #544

(cherry picked from commit b066424)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM pushed a commit that referenced this pull request Aug 15, 2021
See PR #544

(cherry picked from commit b066424)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
RiccardoM added a commit that referenced this pull request Sep 2, 2021
* Version 0.17.3

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Update CHANGELOG.md

* Added the on-chain upgrade handler

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated Cosmos SDK to fix --dry-run

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Version 0.17.6
- Updated Cosmos to v0.42.8
- Added the upgrade handler for the upcoming on-chain upgrade

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated Cosmos SDK to fix the capability issue

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated CHANGELOG

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Removed useless replace from within go.mod

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Release workflow update
Fixed tags not being fetched correctly

* Improve pagination

See PR #544

(cherry picked from commit b066424)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Require chain name to be lowercase

See PR #153

(cherry picked from commit 66e0c98)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Improved profile validation performance

See PR #557

(cherry picked from commit be23505)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Added command to generate chain link JSON

See PR #583

(cherry picked from commit cddb501)

* Changed Ledger app name to Desmos

See PR #590

(cherry picked from commit 91b21f7)

* Updated CHANGELOG

* Removed app migration support

* Removed unused Proto file

* Version 1.0.1

* fix: flag indicator in profile save example

* add: flag indicator in example

* Added changeset entry

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
(cherry picked from commit b40144b)

* Version 1.0.2

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Paul <p22626262@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Wingman L <42913823+ryuash@users.noreply.github.com>
RiccardoM added a commit that referenced this pull request Sep 7, 2021
* Version 0.17.3

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Update CHANGELOG.md

* Added the on-chain upgrade handler

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated Cosmos SDK to fix --dry-run

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Version 0.17.6
- Updated Cosmos to v0.42.8
- Added the upgrade handler for the upcoming on-chain upgrade

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated Cosmos SDK to fix the capability issue

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Updated CHANGELOG

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Removed useless replace from within go.mod

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Release workflow update
Fixed tags not being fetched correctly

* Improve pagination

See PR #544

(cherry picked from commit b066424)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Require chain name to be lowercase

See PR #153

(cherry picked from commit 66e0c98)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Improved profile validation performance

See PR #557

(cherry picked from commit be23505)
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* Added command to generate chain link JSON

See PR #583

(cherry picked from commit cddb501)

* Changed Ledger app name to Desmos

See PR #590

(cherry picked from commit 91b21f7)

* Updated CHANGELOG

* Removed app migration support

* Removed unused Proto file

* Version 1.0.1

* fix: flag indicator in profile save example

* add: flag indicator in example

* Added changeset entry

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
(cherry picked from commit b40144b)

* Version 1.0.2

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

* fix: added missing \ in profile save command example (#602)

(cherry picked from commit 3a73c95)

* Version v1.0.3

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

Co-authored-by: Paul <p22626262@gmail.com>
Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com>
Co-authored-by: Wingman L <42913823+ryuash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace FilteredPaginate with Paginate
2 participants