Change Ledger app name to Desmos #590

RiccardoM · 2021-08-14T12:45:49Z

Description

This PR changes the Ledger app from Cosmos to Desmos. This is done via the following procedure:

Fork cosmos/ledger-cosmos-go into desmos-labs/ledger-desmos-go
Rename the app inside the error message (desmos-labs/ledger-desmos-go@5d87e39)
Replace the ledger-cosmos-go with ledger-desmos-go inside Desmos' go.mod file (this PR).
Update our Cosmos SDK fork to match the change as well (desmos-labs/cosmos-sdk@0e951b4)

Closes #586

Checklist

Targeted PR against correct branch.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote unit tests.
Wrote integration tests (simulation & CLI).
Updated the documentation.
Added an entry to the CHANGELOG.md file.
Re-reviewed Files changed in the Github PR explorer.

codecov · 2021-08-14T12:49:21Z

Codecov Report

Merging #590 (7f1c57c) into master (16e1eeb) will increase coverage by 9.23%.
The diff coverage is 73.00%.

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   75.59%   84.83%   +9.23%     
==========================================
  Files          94       91       -3     
  Lines        4519     5386     +867     
==========================================
+ Hits         3416     4569    +1153     
+ Misses        960      606     -354     
- Partials      143      211      +68

Impacted Files	Coverage Δ
x/commons/commons.go	`100.00% <ø> (ø)`
x/profiles/keeper/msg_server_app_link.go	`0.00% <0.00%> (ø)`
x/profiles/keeper/msg_server_dtag_transfers.go	`74.75% <ø> (-1.72%)`	⬇️
x/profiles/keeper/msg_server_relationships.go	`100.00% <ø> (ø)`
x/profiles/keeper/msgs_server_profile.go	`82.22% <ø> (+5.47%)`	⬆️
x/profiles/keeper/relay_app_links.go	`95.38% <ø> (ø)`
x/profiles/keeper/relay_chain_links.go	`87.09% <ø> (+0.43%)`	⬆️
x/profiles/simulation/decoder.go	`63.15% <ø> (-28.85%)`	⬇️
x/profiles/types/account.go	`56.16% <ø> (+4.75%)`	⬆️
x/profiles/types/codec.go	`100.00% <ø> (ø)`
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddb501...7f1c57c. Read the comment docs.

dadamu

LGTM

See PR #590 (cherry picked from commit 91b21f7)

* Version 0.17.3 Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Update CHANGELOG.md * Added the on-chain upgrade handler Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated Cosmos SDK to fix --dry-run Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Version 0.17.6 - Updated Cosmos to v0.42.8 - Added the upgrade handler for the upcoming on-chain upgrade Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated Cosmos SDK to fix the capability issue Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated CHANGELOG Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Removed useless replace from within go.mod Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Release workflow update Fixed tags not being fetched correctly * Improve pagination See PR #544 (cherry picked from commit b066424) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Require chain name to be lowercase See PR #153 (cherry picked from commit 66e0c98) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Improved profile validation performance See PR #557 (cherry picked from commit be23505) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Added command to generate chain link JSON See PR #583 (cherry picked from commit cddb501) * Changed Ledger app name to Desmos See PR #590 (cherry picked from commit 91b21f7) * Updated CHANGELOG * Removed app migration support * Removed unused Proto file * Version 1.0.1 * fix: flag indicator in profile save example * add: flag indicator in example * Added changeset entry Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> (cherry picked from commit b40144b) * Version 1.0.2 Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Paul <p22626262@gmail.com> Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com> Co-authored-by: Wingman L <42913823+ryuash@users.noreply.github.com>

* Version 0.17.3 Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Update CHANGELOG.md * Added the on-chain upgrade handler Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated Cosmos SDK to fix --dry-run Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Version 0.17.6 - Updated Cosmos to v0.42.8 - Added the upgrade handler for the upcoming on-chain upgrade Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated Cosmos SDK to fix the capability issue Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Updated CHANGELOG Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Removed useless replace from within go.mod Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Release workflow update Fixed tags not being fetched correctly * Improve pagination See PR #544 (cherry picked from commit b066424) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Require chain name to be lowercase See PR #153 (cherry picked from commit 66e0c98) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Improved profile validation performance See PR #557 (cherry picked from commit be23505) Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * Added command to generate chain link JSON See PR #583 (cherry picked from commit cddb501) * Changed Ledger app name to Desmos See PR #590 (cherry picked from commit 91b21f7) * Updated CHANGELOG * Removed app migration support * Removed unused Proto file * Version 1.0.1 * fix: flag indicator in profile save example * add: flag indicator in example * Added changeset entry Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> (cherry picked from commit b40144b) * Version 1.0.2 Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * fix: added missing \ in profile save command example (#602) (cherry picked from commit 3a73c95) * Version v1.0.3 Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Paul <p22626262@gmail.com> Co-authored-by: Leonardo Bragagnolo <leo.braga95@gmail.com> Co-authored-by: Wingman L <42913823+ryuash@users.noreply.github.com>

RiccardoM added 2 commits August 14, 2021 14:37

Changed the Ledger app name to Desmos

d836578

Added CHANGELOG entry

7885f36

RiccardoM requested review from dadamu and leobragaz August 14, 2021 12:45

RiccardoM added this to the v1.0.0 milestone Aug 14, 2021

RiccardoM added 2 commits August 14, 2021 15:40

Merge branch 'master' into riccardo/ledger-app-name-change

3179131

Fixed the tests

7f1c57c

RiccardoM enabled auto-merge (squash) August 14, 2021 14:18

dadamu approved these changes Aug 14, 2021

View reviewed changes

RiccardoM merged commit 91b21f7 into master Aug 14, 2021

RiccardoM deleted the riccardo/ledger-app-name-change branch August 14, 2021 15:03

RiccardoM added a commit that referenced this pull request Aug 14, 2021

Changed Ledger app name to Desmos

8bbae83

See PR #590 (cherry picked from commit 91b21f7)

RiccardoM added a commit that referenced this pull request Aug 15, 2021

Changed Ledger app name to Desmos

c4c0796

See PR #590 (cherry picked from commit 91b21f7)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Ledger app name to Desmos #590

Change Ledger app name to Desmos #590

RiccardoM commented Aug 14, 2021 •

edited

codecov bot commented Aug 14, 2021 •

edited

dadamu left a comment

Change Ledger app name to Desmos #590

Change Ledger app name to Desmos #590

Conversation

RiccardoM commented Aug 14, 2021 • edited

Description

Checklist

codecov bot commented Aug 14, 2021 • edited

Codecov Report

dadamu left a comment

Choose a reason for hiding this comment

RiccardoM commented Aug 14, 2021 •

edited

codecov bot commented Aug 14, 2021 •

edited