Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix posts query paths version #978

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jul 27, 2022

Description

This PR fixes the currently wrong path inside the x/posts gRPC query method.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #978 (16c33a1) into master (987ec5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         172      172           
  Lines       15244    15244           
=======================================
  Hits        12277    12277           
  Misses       2440     2440           
  Partials      527      527           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b25d93...16c33a1. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jul 27, 2022
@mergify mergify bot merged commit b292363 into master Jul 27, 2022
@mergify mergify bot deleted the riccardom/fix-posts-queries-endpoints branch July 27, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants