Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing subspaces authz migration #981

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jul 29, 2022

Description

This PR adds the x/subspaces authorization migrations that was missing from v4.2.0.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@github-actions github-actions bot added the x/subspaces Issue on the x/subspaces module label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #981 (b79173e) into master (987ec5d) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head b79173e differs from pull request most recent head 36324b7. Consider uploading reports for the commit 36324b7 to get more accurate results

@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   80.53%   80.53%   -0.01%     
==========================================
  Files         172      174       +2     
  Lines       15244    15274      +30     
==========================================
+ Hits        12277    12301      +24     
- Misses       2440     2444       +4     
- Partials      527      529       +2     
Impacted Files Coverage Δ
x/subspaces/legacy/v4/store.go 76.00% <76.00%> (ø)
x/subspaces/legacy/v2/codec.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da714ce...36324b7. Read the comment docs.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM changed the title fix: missing subspaces authz migration fix: add missing subspaces authz migration Jul 29, 2022
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jul 29, 2022
@dadamu
Copy link
Contributor

dadamu commented Jul 29, 2022

Some tests are error.

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM
Copy link
Contributor Author

Some tests are error.

Fixed

@mergify mergify bot merged commit 48fc886 into master Jul 29, 2022
@mergify mergify bot deleted the riccardom/fix-subspaces-authz-migration branch July 29, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/subspaces Issue on the x/subspaces module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants