Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search #27

Open
dessalines opened this issue Jan 14, 2022 · 5 comments
Open

Search #27

dessalines opened this issue Jan 14, 2022 · 5 comments
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request

Comments

@dessalines
Copy link
Member

dessalines commented Jan 14, 2022

Implement in-app searching of all content, not just communities.

@bhcompy
Copy link

bhcompy commented Jun 12, 2023

Would the scope of this include search comments in post (that is, open a large post with hundreds of comments, I want to search the thread for specific keywords)? I see other issues closed as duplicates to this general search, but want to make sure this isn't a separate use case, as it's not an ask to search across communities or across threads, just in the focused post that is open (like ctrl+f)

@twizmwazin
Copy link
Contributor

I think this encompasses all search features currently exposed in the web UI. Anything not supported there is likely unsupported in the API, and an issue would need to be raised and implemented on the server before we can do anything here.

@bhcompy
Copy link

bhcompy commented Jun 12, 2023

Conceptually, though, I'm not really asking to search through the API, rather just search what is returned within the application, similar to ctrl-f through a desktop (which also doesn't rely directly on API/HTTP calls, just searches on already returned and formatted data).

@twizmwazin
Copy link
Contributor

I see. I think that would have a lot edge cases to consider, like not all comments being automatically loaded on big threads where this would be most useful, but doesn't seem impossible. It is definitely out of scope of this current issue, however.

@twizmwazin twizmwazin added the 4 - medium/high priority Issue needs to be fixed soon, does not break core functionality label Jun 14, 2023
@marsara9
Copy link

I can create a separate issue for this, but what about just using my https://www.lemmy-search.com/ ? i.e. have the search feature in jabora use my APIs as an alternative to the built-in Lemmy API.

I currently only support searching posts and communities but users may come soon-ish.

This search engine also allows for more complex queries than what is currently supported inside Lemmy.

More details here: https://www.github.com/marsara9/lemmy-search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants