Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite links in /c/community@server or /u/user@server in appropriate ways #454

Closed
Barbariandude opened this issue Jun 7, 2023 · 4 comments
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request

Comments

@Barbariandude
Copy link

Barbariandude commented Jun 7, 2023

In lemmy-ui, a link formatted in the ways described in the title are automatically rewritten to the appropriate URL by prepending the URL of the instance the account is from. This functionality is missing from Jerboa. Not the most urgent thing in the world as users can use the website instead, but definitely something that should be looked at at some point.

@Barbariandude Barbariandude added the enhancement New feature or request label Jun 7, 2023
@dessalines
Copy link
Member

Is this referring to the copy permalink button? Or content that's in the markdown fields?

If its the permalink, we should probably use the original links, and if its the latter, jerboa doesn't even have a smart auto-filler for users and communities yet like lemmy-ui does.

And when it does, we'll need to match lemmy-ui, and add both links (a local and a fedi-link) : LemmyNet/lemmy-ui#1048

@Barbariandude
Copy link
Author

Barbariandude commented Jun 9, 2023

If I format a link like [this](/c/lemmy@lemmy.ml) in the web UI, then other users see the link as https://my.server/c/lemmy@lemmy.ml. This is very useful functionality once people get used to it. It would be nice if the functionality matched in Jerboa.

@a1studmuffin
Copy link
Contributor

There's a good example here:

https://lemmy.ml/comment/482011

The link works fine in the web UI but not in Jerboa.

@beatgammit
Copy link
Contributor

This has been merged and I believe resolved.

@MV-GH MV-GH closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - medium/high priority Issue needs to be fixed soon, does not break core functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants