Adding admin / mod view votes. #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
changed the title
|
|
|
If there too many more actions that need to be added, maybe we should explore other options, move all mod actions into a sub menu or add a mod button next to the dot menu which shows all the mod actions. Doesn't need to be addressed in this PR This is especially needed at some point because that menu is most likely not scrollable, and phones with smaller viewport will definitely experience problems |
MV-GH
reviewed
Jan 25, 2024
app/src/main/java/com/jerboa/ui/components/post/composables/PostOptionsDropdown.kt
Outdated
Show resolved
Hide resolved
Very good point, and it makes sense to add a moderation sub-menu. I'll mark as ready for review when I get done with that. |
MV-GH
reviewed
Jan 30, 2024
app/src/main/java/com/jerboa/ui/components/post/composables/PostOptionsDropdown.kt
Outdated
Show resolved
Hide resolved
MV-GH
reviewed
Jan 30, 2024
app/src/main/java/com/jerboa/ui/components/viewvotes/post/PostLikesActivity.kt
Show resolved
Hide resolved
MV-GH
reviewed
Jan 30, 2024
app/src/main/java/com/jerboa/ui/components/viewvotes/comment/CommentLikesActivity.kt
Show resolved
Hide resolved
- Moving padding up to Box. - Using alternate feature flag method.
MV-GH
approved these changes
Feb 1, 2024
MV-GH
approved these changes
Feb 1, 2024
dessalines
added a commit
that referenced
this pull request
Feb 7, 2024
* Starting to work on admin_view_votes, needs API added yet. * Finished up adding admin view votes. * Fix package name. * Upping lemmy-api version. * Adding a moderation subfield to post and comment action dropdowns. * Adding feature flag check. * Addressing PR comments. - Moving padding up to Box. - Using alternate feature flag method.
dessalines
added a commit
that referenced
this pull request
Feb 12, 2024
* Starting to work on registration applications. * Remove ImmutableList and add stability config file (#1342) * Adding admin / mod view votes. (#1331) * Starting to work on admin_view_votes, needs API added yet. * Finished up adding admin view votes. * Fix package name. * Upping lemmy-api version. * Adding a moderation subfield to post and comment action dropdowns. * Adding feature flag check. * Addressing PR comments. - Moving padding up to Box. - Using alternate feature flag method. * Temp workaround for compose-settings height bug. (#1345) - See alorma/Compose-Settings#203 - Fixes #1338 * Swipe post/comment to upvote/downvote/reply/save (#1327) * SwipeToAction composable * Swipe to downvote/upvote feature implemented with preset-based customization * Fix kotlin format * fix string resource * Do not use SwipeToAction when it is disabled * Improve scrolling experience * Increase color shift animation speed * Improve ranges * new preset: only votes * fix deltas & rename resources * SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges * Kotlin format * use ordinal of enum in AppDB instead of int * Fixed behaviour when downvotes disables/when not logged in * Fix formatting * Remove default param for enableDownVotes in SwipeToAction * Fix colors for swipe actions * Fixed lambda caching in rememberSwipeActionState * Format kotlin --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com> * Almost finished viewmodel. * A few more additions. * Finishing up registration applications. * Adding a locally generated changelog. - Adds a last_version_code_viewed, that gets updated in the DB, and compared against the current version to show the changelog. This means we never have to manually update that column again. - Add a generate_changelog.sh script that uses git-cliff. It copies the changelog into code assets, which can be done before the release. - Fixes #1272 * Removing 27 schema * Removing 27 schema 2 * Moving changelog fetching to viewModel. * Persisting admin and mod status to DB. * Fixing format. * Removing weird changes. * Don't display bottomNav until acc loads * Fix formatting * Fix swapToAnon invalidating jwt + fix navbar not showing for anon --------- Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com> Co-authored-by: Mikhail Loginov <32912696+Snow4DV@users.noreply.github.com> Co-authored-by: maarten.vercruysse <maarten.vercruysse@outlook.be>
dessalines
added a commit
that referenced
this pull request
Feb 14, 2024
* Starting to work on registration applications. * Remove ImmutableList and add stability config file (#1342) * Adding admin / mod view votes. (#1331) * Starting to work on admin_view_votes, needs API added yet. * Finished up adding admin view votes. * Fix package name. * Upping lemmy-api version. * Adding a moderation subfield to post and comment action dropdowns. * Adding feature flag check. * Addressing PR comments. - Moving padding up to Box. - Using alternate feature flag method. * Temp workaround for compose-settings height bug. (#1345) - See alorma/Compose-Settings#203 - Fixes #1338 * Swipe post/comment to upvote/downvote/reply/save (#1327) * SwipeToAction composable * Swipe to downvote/upvote feature implemented with preset-based customization * Fix kotlin format * fix string resource * Do not use SwipeToAction when it is disabled * Improve scrolling experience * Increase color shift animation speed * Improve ranges * new preset: only votes * fix deltas & rename resources * SwipeToAction implemented correctly, SwipeToDismiss replaced with SwipeToDismissBox, fixed swipe ranges * Kotlin format * use ordinal of enum in AppDB instead of int * Fixed behaviour when downvotes disables/when not logged in * Fix formatting * Remove default param for enableDownVotes in SwipeToAction * Fix colors for swipe actions * Fixed lambda caching in rememberSwipeActionState * Format kotlin --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com> * Almost finished viewmodel. * A few more additions. * Finishing up registration applications. * Adding a locally generated changelog. - Adds a last_version_code_viewed, that gets updated in the DB, and compared against the current version to show the changelog. This means we never have to manually update that column again. - Add a generate_changelog.sh script that uses git-cliff. It copies the changelog into code assets, which can be done before the release. - Fixes #1272 * Removing 27 schema * Removing 27 schema 2 * Adding the admin / mod report queue. * Moving changelog fetching to viewModel. * Persisting admin and mod status to DB. * Fixing format. * Removing weird changes. * Missed formatting. * Forgot to remove unused block. * Fixing missing fullBody. * Addressing PR comments. --------- Co-authored-by: Maarten Vercruysse <67873169+MV-GH@users.noreply.github.com> Co-authored-by: Mikhail Loginov <32912696+Snow4DV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tested and working now.
VID_20240123_181945.mp4