Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancom theme #509

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Add ancom theme #509

merged 9 commits into from
Oct 18, 2023

Conversation

Kommynct
Copy link
Contributor

added ancom colors

I'm very inexperienced, and I'm fairly certain I need to add these colors to a list somewhere, but I'm not sure where, please advise

I also don't know how to test my changes, a link to some documentation for how to do that would be very helpful, but I believe this is correct.

add ancom colors
@Kommynct Kommynct changed the title Update Color.kt Add ancom theme Oct 17, 2023
@Kommynct
Copy link
Contributor Author

Colors actually double checked and tested with android studio thanks to wadeypie

@KraXen72
Copy link
Contributor

run gradlew formatKotlin in the thumb-key root directory to pass lint checks

@dessalines
Copy link
Owner

Check the CI as well, its telling you of a naming error.

@Kommynct
Copy link
Contributor Author

Should be ready now!

@dessalines
Copy link
Owner

More errors bc you didn't build / test it. Check the ci.

@Kommynct
Copy link
Contributor Author

I'm sorry, i'm trying my best and, as is intensely obvious, I have no idea what i'm doing.

I checked the CI's, it says it's good now, and I built it on my phone and it's working there, sorry again!

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No probs, these are good learning opportunities, its how we all start!

@dessalines dessalines merged commit 2a094ce into dessalines:main Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants