Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ITTypeSplit.kt #540

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Update ITTypeSplit.kt #540

merged 5 commits into from
Nov 8, 2023

Conversation

flauta
Copy link
Contributor

@flauta flauta commented Oct 29, 2023

moved vowels to right, consonants to left
reordered on letter frequency order
added schwa and reversed-E symbols

@flauta
Update ITTypeSplit.kt
467dac6 
moved vowels to right, consonants to left
reordered on letter frequency order
added schwa and reversed-E symbols
dessalines
dessalines requested changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting check failed, run ./gradlew formatKotlin to pass lint.

app/src/main/java/com/dessalines/thumbkey/keyboards/ITTypeSplit.kt Outdated
@@ -547,7 +574,7 @@ val KB_IT_TYPESPLIT_SHIFTED = KeyboardC(
)

val KB_IT_TYPESPLIT: KeyboardDefinition = KeyboardDefinition(
title = "italiano type-split",
title = "IT Type-Split italiano",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back to the old title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @dessalines, I have updated the line changing it back but I don't know what I should do now

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its no problem, I'll clean this and the other PRs up when I do the next release, just keep it open for now.

@flauta
Update ITTypeSplit.kt
964caba 
reverted line 577 definition title
@dessalines
Copy link
Owner

Even before my merge from main, this was riddled with typos and errors. Please do a better job next time.

@dessalines dessalines enabled auto-merge (squash) November 8, 2023 14:29
@dessalines dessalines merged commit 04c04cf into dessalines:main Nov 8, 2023
1 check was pending
@flauta flauta deleted the flauta-patch-1 branch November 8, 2023 18:04
@flauta
Copy link
Contributor Author

flauta commented Nov 8, 2023

Thanks @dessalines for fixing the PR, and to accept a low-quality work as my work is.
I'm not a professional programmer and I can't compile on my own, so if you can suggest me a way to check my code before committing (other than reading many times the source as I do), maybe I'd be able to reduce or avoid typos and errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flauta @dessalines