Fix #304: Improve Utils.autoCapitalizeCheck #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Instead of manually reading the `getTextBeforeCursor`, use `IMEService.currentInputConnection.getCursorCapsMode` to detect whether auto-capitalization should happen. This fixes dessalines#304, where terminal emulator apps like Termux, JuiceSSH, KDE Connect, etc., which provide an empty input connection to Thumb-Key, would always be auto-capitalized.
mpsijm
force-pushed
the
304-improve-auto-capitalize
branch
from
ddbe326
to
7d5d556
Compare
dessalines
reviewed
May 14, 2024
|
I tested this in JuiceSSH, and it works there 🙂 Too bad that it doesn't work in Termux, but this fix would help me 😇 This is a screenrec using a dev version of Thumb-Key compiled from this branch: Screen_Recording_20240514_090030_JuiceSSH.mp4Before this fix, every letter would be capitalized. EDIT: Can also confirm that Termux still capitalizes every letter, even with this fix. I'd almost say that Termux incorrectly sets the "caps mode". But then other keyboards should have the same problem, which is not the case (tested FlickBoard, Kii Keyboard, and Samsung Keyboard) 😛 |
dessalines
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually reading the
getTextBeforeCursor, useIMEService.currentInputConnection.getCursorCapsModeto detect whether auto-capitalization should happen.This fixes #304, where terminal emulator apps like Termux, JuiceSSH, KDE Connect, etc., which provide an empty input connection to Thumb-Key, would always be auto-capitalized.