Fix #304 (take two): In Utils.autoCapitalizeCheck, use input type of current editor #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t type of current editor I checked the documentation[1] again, and it says about `reqModes`: > [...] you can simply pass the current `TextBoxAttribute.contentType` > value directly in to here. I assume that `ime.currentInputEditorInfo.inputType` is what we're looking for, in that case 😄 To make sure that this can be tested in the TestOutTextField, I set it to auto-capitalize sentences. [1]: https://developer.android.com/reference/android/view/inputmethod/InputConnection#getCursorCapsMode(int)
mpsijm
force-pushed
the
304-auto-capitalize-from-input-type
branch
from
dbc986e
to
3adb2b1
Compare
dessalines
approved these changes
May 21, 2024
|
No problem, thanks for merging! 😄 The apps that I tested, appear to use the standard correctly 🙂 I just misunderstood the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the documentation again, and it says about
reqModes:I assume that
ime.currentInputEditorInfo.inputTypeis what we're looking for, in that case 😄To make sure that this can be tested in the
TestOutTextField, I set it to auto-capitalize sentences.Besides the test-out text field, I've tested this in these apps, and it looks like everything is as expected:
Hopefully, this really fixes #304 😄