Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning ranges not consistent with editor content #57

Closed
karollewandowski opened this issue Dec 29, 2019 · 2 comments
Closed

Warning ranges not consistent with editor content #57

karollewandowski opened this issue Dec 29, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@karollewandowski
Copy link

karollewandowski commented Dec 29, 2019

Please see recording: https://i.imgur.com/dcc9gDf.mp4.

Maybe there is some inconsistency in computing indentations?

It was recorded in IntelliJ IDEA Ultimate 2019.3.

EDIT:
After a few more tests it looks like analysis is run with delay (what is reasonable) and if we insert some new text before annotated text, then it breaks positions. Sometimes it's fixed after a moment and sometimes stays broken until I type anything what is pretty annoying and distracting.

@arturbosch arturbosch added bug Something isn't working help wanted Extra attention is needed labels Jan 8, 2020
@ahampe
Copy link

ahampe commented Feb 5, 2020

The annotator in this plugin receives PsiFiles which are updated as you edit, but, interestingly, the VirtualFiles associated with them aren't updated, at least from my debugging. Perhaps some kind of caching issue? I would think the fix would be making it so that the core detekt library can analyze PsiFiles directly so that the highlights can be applied accurately, or somehow triggering an update of the virtual file and waiting for it to reflect the changes in the PsiFile. I don't know how to implement either of these, just wanted to note.

@karollewandowski
Copy link
Author

Hi, when can we expect 1.0.0-RC1 available in plugins repo? I can see that both tasks from this milestone are finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants