Fix crash for DontDowncastCollectionTypes on Synthetic types (#3776)

detekt · May 14, 2021 · 1c1dd07 · 1c1dd07
1 parent c2a237d
commit 1c1dd07
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...one/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/DontDowncastCollectionTypes.kt b/...one/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/DontDowncastCollectionTypes.kt
@@ -67,7 +67,7 @@ class DontDowncastCollectionTypes(config: Config) : Rule(config) {
         val lhsType = left
             .getType(bindingContext)
             ?.fqNameOrNull()
-            ?.shortName()
+            ?.shortNameOrSpecial()
             ?.asString()
 
         val rhsType = right

diff --git a/...src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/DontDowncastCollectionTypesSpec.kt b/...src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/DontDowncastCollectionTypesSpec.kt
@@ -3,6 +3,7 @@ package io.gitlab.arturbosch.detekt.rules.bugs
 import io.gitlab.arturbosch.detekt.api.Config
 import io.gitlab.arturbosch.detekt.rules.setupKotlinEnvironment
 import io.gitlab.arturbosch.detekt.test.compileAndLintWithContext
+import io.gitlab.arturbosch.detekt.test.lintWithContext
 import org.assertj.core.api.Assertions.assertThat
 import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
 import org.spekframework.spek2.Spek
@@ -174,7 +175,7 @@ class DontDowncastCollectionTypesSpec : Spek({
                 assertThat(result).isEmpty()
             }
 
-            it("detects Map type casts") {
+            it("ignores Map type casts") {
                 val code = """
                 fun main() {
                     val myMap = mutableMapOf(1 to 2)
@@ -184,6 +185,17 @@ class DontDowncastCollectionTypesSpec : Spek({
                 val result = subject.compileAndLintWithContext(env, code)
                 assertThat(result).isEmpty()
             }
+
+            it("ignores Synthetic types") {
+                val code = """
+                import kotlinx.android.synthetic.main.tooltip_progress_bar.view.*
+                fun main() {
+                    val params = tooltip_guide.layoutParams as LayoutParams
+                }
+                """
+                val result = subject.lintWithContext(env, code)
+                assertThat(result).isEmpty()
+            }
         }
 
         describe("type-aliases") {